SheepAspect

New Post: SheepAspect + ILMerge

winsto — Sat, 11 May 2013 19:53:32 GMT

I tried ILMerging SheepAspect, SheepAspect.Tasks, Antlr.. and dependencies together into one combined assembly and found that the PostCompileWeave Task did not weave in the aspects. I did not look too deeply into why this was the case. Incidentally in my case I was trying to do this to avoid a clash between Sheep's dependency on Antlr 3.3.... and another project having a dependency on Antlr 3.2..... I did a quick test with ILMerge and gave up when the aspects were not woven to look at other workarounds.

Hope this helps.

New Post: Getting 'value' in around property setter advice

winsto — Sat, 11 May 2013 19:46:54 GMT

David,

I know this is a late response, but I came across your question whilst working out Around Property advice with Sheep myself. So maybe my response can help someone.

I believe the parameter 'value' to be used in the property 'Set' is in the Args array jp.Args[0] if you need access to it. To have it set just call jp.Execute.

Incidentally accessing the current property as you do above in 'Getter' around advice (I know you are not doing this, but in case it helps others as I didn't spot this at first) will result in a StackOverflowException as the 'Getter' advice will just be repeatedly, recursively called.

New Post: SheepAspect + ILMerge

hendryluk — Thu, 09 May 2013 13:36:49 GMT

I personally have not tried ILMerging any SheepAspect project, but in theory I can't see any reason why it would be different. Just to check, does the SampleAspect produce any output without ILMerge?

New Post: SheepAspect + ILMerge

adamjohnson — Wed, 08 May 2013 01:19:55 GMT

Is it possible to use ILMerge and SheepAspect together? I want to have one assembly for my aspect oriented library (AOP.dll). Here is my current post-build on my project:

"$(SolutionDir)packages\ilmerge.2.13.0307\ilmerge.exe" /target:library /out:"$(TargetDir)AOP.dll" "$(TargetDir)AOPTemp.dll" "$(TargetDir)Antlr3.Runtime.dll" "$(TargetDir)Mono.Cecil.dll" "$(TargetDir)Mono.Cecil.mdb.dll" "$(TargetDir)Mono.Cecil.pdb.dll" "$(TargetDir)Mono.Cecil.rocks.dll" "$(TargetDir)SheepAspect.dll"

The command completes successfully and the merged dll is created; however, when I run my sample application, the SampleAspect does not produce any output. Any suggestions?

New Post: SheepAspect SelectConstructors SAQL Syntax Help!!..

Muruganalagesan — Tue, 07 May 2013 13:30:25 GMT

Hi hendryluk ,
I have posted a similar question in issue tracker,(just moving it to discussion) to get a feasible solution
Issue tracker link
I have tried your solution with 'SelectConstructors' ,but with no success and i will be listing the options I have tried so far.
Can you help me on that?

Code

class Program
    {
        static void Main()
        {
            

            StreamWriter sw = new StreamWriter(@"E:\AOP\sheepaspect-76419\SheepAspectCompiler\bin\Debug\Test\sample.txt");

            Console.ReadLine();
        }
}

Aspect Defintion

SelectConstructors("InType:'System.IO.StreamWriter'")]
        public void StreamWriterCreate()
        { }
        [Around("StreamWriterCreate")]
         public void DemoAdvice2(CallMethodJointPoint    jp)
        {
            Console.WriteLine("Checking constructor aspect", jp.This );
            
        }

YI: I have tried query with SAQL Query Analyser,but with no success.

Can you please let me know how to do the above aspect process(since in critical time frame to do it).

Looking forward for your reply
Regards,
Murugan

Commented Issue: SheepAspect SelectConstructors SAQL Syntax [10947]

Muruganalagesan — Thu, 25 Apr 2013 07:24:26 GMT

Hi Henry,
Is it possible to apply aspect for constructors using sheep aspect? If possible please provide me examples SAQL syntax for me

__Examples:__
StreamWriter sw= New StreamWriter("some path");

Please provide SAQL for the above. so that i can use it as a template...

Looking forward to hear from you...
Comments: ** Comment from web user: Muruganalagesan **

Hi hendryluk ,
Thanks for your speedy response.
I have tried your solution with 'SelectConstructors' ,but with no success and i will be listing the options I have tried so far.
Can you help me on that?

* __MyProgram Class:__

```
class Program
{
static void Main()
{

StreamWriter sw = new StreamWriter(@"E:\AOP\sheepaspect-76419\SheepAspectCompiler\bin\Debug\Test\sample.txt");

Console.ReadLine();
}
}
```
============================================================
* __My Aspect Definition:__

```
[SelectConstructors("InType:'System.IO.StreamWriter'")]
public void StreamWriterCreate()
{ }
[Around("StreamWriterCreate")]
public void DemoAdvice2(CallMethodJointPoint jp)
{
Console.WriteLine("Checking constructor aspect", jp.This );

}
```

FYI: I have tried query with SAQL Query Analyser,but with no success.

Can you please let me know how to do the above aspect process(since in critical time frame to do it).

Looking forward for your reply
Regards,
Murugan

Commented Issue: SheepAspect SelectConstructors SAQL Syntax [10947]

hendryluk — Thu, 25 Apr 2013 02:01:56 GMT

Yes, there's a [SelectConstuctor] attribute which works almost exactly as a [SelectMethod] attribute (i.e. it accepts the same SAQL syntax).
So in your instance: [SelectConstructor("InType: System.Io.StreamWriter")]

Created Issue: SheepAspect SelectConstructors SAQL Syntax [10947]

Muruganalagesan — Wed, 24 Apr 2013 14:55:45 GMT

Commented Issue: SheepAspect won't do postcompile weaving in TeamCity build [9402]

hendryluk — Thu, 11 Apr 2013 08:04:06 GMT

When we are building locally SheepAspect works like a charm, but when we build via TeamCity we get the following error:
-----
D:\TCData\Work\e78aa496ea756bf6\packages\SheepAspect.0.2.0.1\tools\SheepAspect.targets(4, 5): System.NullReferenceException: Object reference not set to an instance of an object.
at SheepAspect.Tasks.PostCompileWeaveTask.Execute()
Comments: ** Comment from web user: hendryluk **

Hi,
I can't seem to replicate the same error in TeamCity.
What build method do you use in TC?
I use sln build against this public repository: https://github.com/hendryluk/SheepAspectPlay, and it seems to build successfully on TC.
Is there anything specific with your TeamCity build configuration?
Otherwise maybe you can try using your TC configuration against https://github.com/hendryluk/SheepAspectPlay to test?
Please let me know how it goes.

Commented Issue: SheepAspect won't do postcompile weaving in TeamCity build [9402]

swingsetacid — Wed, 10 Apr 2013 22:46:11 GMT

We're getting a similar issue when running in TeamCity. Builds work fine locally, but don't on the build agent. Below are the exception and fusion loader logs. It looks like the loader is attempting to load SheepAspect from the Tools directory, not the Lib directory. Anyone else experiencing the same issue?

Thanks!

------------------------------
System.IO.FileNotFoundException: Could not load file or assembly 'SheepAspect, Version=0.3.0.11, Culture=neutral, PublicKeyToken=null' or one of its dependencies. The system cannot find the file specified.
File name: 'SheepAspect, Version=0.3.0.11, Culture=neutral, PublicKeyToken=null'
at SheepAspect.Tasks.AppDomainIsolatedDiscoveryRunner.Process(String configFile, TaskLoggingHelper logger, String[]& weavedFiles)
at SheepAspect.Tasks.PostCompileWeaveTask.Execute()

Assembly manager loaded from: C:\Windows\Microsoft.NET\Framework64\v4.0.30319\clr.dll
Running under executable C:\Windows\Microsoft.NET\Framework64\v4.0.30319\MSBuild.exe
--- A detailed error log follows.

=== Pre-bind state information ===
LOG: DisplayName = SheepAspect, Version=0.3.0.11, Culture=neutral, PublicKeyToken=null
(Fully-specified)
LOG: Appbase = file:///C:/Windows/Microsoft.NET/Framework64/v4.0.30319/
LOG: Initial PrivatePath = NULL
Calling assembly : SheepAspect.Tasks, Version=0.3.0.11, Culture=neutral, PublicKeyToken=null.
===
LOG: This bind starts in LoadFrom load context.
WRN: Native image will not be probed in LoadFrom context. Native image will only be probed in default load context, like with Assembly.Load().
LOG: Using application configuration file: C:\Windows\Microsoft.NET\Framework64\v4.0.30319\MSBuild.exe.Config
LOG: Using host configuration file:
LOG: Using machine configuration file from C:\Windows\Microsoft.NET\Framework64\v4.0.30319\config\machine.config.
LOG: Policy not being applied to reference at this time (private, custom, partial, or location-based assembly bind).
LOG: Attempting download of new URL file:///C:/Windows/Microsoft.NET/Framework64/v4.0.30319/SheepAspect.DLL.
LOG: Attempting download of new URL file:///C:/Windows/Microsoft.NET/Framework64/v4.0.30319/SheepAspect/SheepAspect.DLL.
LOG: Attempting download of new URL file:///C:/Windows/Microsoft.NET/Framework64/v4.0.30319/SheepAspect.EXE.
LOG: Attempting download of new URL file:///C:/Windows/Microsoft.NET/Framework64/v4.0.30319/SheepAspect/SheepAspect.EXE.
LOG: Attempting download of new URL file:///C:/TeamCity/buildAgent/work/f957c9968fa39b59/WTL/packages/SheepAspect.0.3.0.11/Tools/SheepAspect.DLL.
LOG: Attempting download of new URL file:///C:/TeamCity/buildAgent/work/f957c9968fa39b59/WTL/packages/SheepAspect.0.3.0.11/Tools/SheepAspect/SheepAspect.DLL.
LOG: Attempting download of new URL file:///C:/TeamCity/buildAgent/work/f957c9968fa39b59/WTL/packages/SheepAspect.0.3.0.11/Tools/SheepAspect.EXE.
LOG: Attempting download of new URL file:///C:/TeamCity/buildAgent/work/f957c9968fa39b59/WTL/packages/SheepAspect.0.3.0.11/Tools/SheepAspect/SheepAspect.EXE.

Patch Applied: #11884

hendryluk — Thu, 28 Mar 2013 03:57:55 GMT

hendryluk has applied patch #11884.

Comment:
A different method of creating AppDomain has been applied to address this issue.

New Post: SheepAspect - cool project, unfortunately currently not usuable.

hendryluk — Thu, 28 Mar 2013 03:18:25 GMT

Yes the source-code on the repository is currently the same as the latest NuGet version.

Patch Applied: #13703

hendryluk — Wed, 27 Mar 2013 23:52:10 GMT

hendryluk has applied patch #13703.

Comment:
Patch applied. Thanks

New Post: SheepAspect - cool project, unfortunately currently not usuable.

avinamal — Wed, 27 Mar 2013 23:46:12 GMT

Just one last question as it's not completely clear from the site - Is the source downloadable from here the latest version? i.e. installing from NuGet results in same binaries as building the source downloaded from this site?
Thanks!

New Post: SheepAspect - cool project, unfortunately currently not usuable.

hendryluk — Wed, 27 Mar 2013 06:18:40 GMT

Hi Avinamal.
Thanks for the efforts and the support. Feedbacks and bug reports from early adopters are very helpful for the project to gain maturity it desperately needs, so keep them coming :)
One potential issue I can see from your initial implementation (which may or may not be related to the issue you were having) is a possibility of StackOverflowException, i.e. if your class overrides the ToString() method, when your logging aspect make a ToString() invocation, it may trigger a further (undesired) logging.
Regarding the out (or ref) parameter, frankly it's one of the CLR features I have not really tested nor supported. I will definitely have a look into it, and add it to the bug-list if it's found to be broken (which i strongly suspect it is).
But in the meantime if you're having another issue or difficulty, please do give me a shout.

New Post: SheepAspect - cool project, unfortunately currently not usuable.

avinamal — Wed, 27 Mar 2013 05:47:03 GMT

Dear Mr. Hendryluk,

Thanks for the kind words, I'm ready to suffer to some extent if the final result will be using your project!

I think I've found my bug and it has nothing to do with SheepAspect (I think).
The actual Exception was thrown on invoking public method with out parameter.
I was trying to log jp.Args from my Aspect, and for some reason - an out parameter throws a NullReferenceException on ToString() - even when it's clearly not null.
Another bug I had is not to exclude ToString() from the Aspect selection - I think that what made the exception a total CLR crash.

Currently, just by adding & !Name: 'ToString' to the attribute, and try-catching around String.Join(",", jp.Args) - my problems are solved :-)

Sorry for the harsh words with which I've opened this thread... That's just frustration speaking.

Thanks and keep on the great job!

New Post: SheepAspect - cool project, unfortunately currently not usuable.

hendryluk — Sun, 24 Mar 2013 22:01:41 GMT

Sorry for all the pain. Would you be able to send me some sample code? Im suspecting you may be touching specific areas that are not yet properly supported (such as weaving CLR events).
Cheers

New Post: SheepAspect - cool project, unfortunately currently not usuable.

avinamal — Sat, 23 Mar 2013 01:25:37 GMT

I've tried to build a minimal Sheep app to demonstrate the crash, only it didn't crash. So calling a Fanc that accepts an interface, by itself, is not enough to reproduce the crash. I'm working with the sample Aspect BTW (just changed the returned value to object).

New Post: SheepAspect - cool project, unfortunately currently not usuable.

avinamal — Fri, 22 Mar 2013 22:50:23 GMT

I think I've ruled out x64/x86 mismatch as source of crash, as I've targeted all dependencies to x86 and still crush on entering the Func.
Let's see if replacing the Func does the trick...

New Post: SheepAspect - cool project, unfortunately currently not usuable.

avinamal — Fri, 22 Mar 2013 22:24:35 GMT

I think I've ruled out x64/x86 mismatch as source of crash, as I've targeted all dependencies to x86 and still crush on entering the Func.
Let's see if replacing the Func does the trick...